linux-kernel - Re: [PATCH v3] misc: adds support the FSA9480 USB Switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110308210227.GA12804@redhat.com>
Date:	Tue, 8 Mar 2011 16:02:27 -0500
From:	Dave Jones <davej@...hat.com>
To:	Minkyu Kang <mk7.kang@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	kyungmin.park@...sung.com, Ben Dooks <ben-i2c@...ff.org>
Subject: Re: [PATCH v3] misc: adds support the FSA9480 USB Switch

On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote:

 > +static DEVICE_ATTR(switch, S_IRUGO | S_IWUGO,
 > +		fsa9480_show_manualsw, fsa9480_set_manualsw);
 
This probably shouldn't be world writable if it's writing to hardware.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/