linux-kernel - Re: + sysctl-add-proc_dointvec_unsigned-handler.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=-PcbpBjWZuno1fjwZD-tGmC+JMxrzMr1FNwu7@mail.gmail.com>
Date:	Tue, 8 Mar 2011 13:15:11 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: + sysctl-add-proc_dointvec_unsigned-handler.patch added to -mm tree

On Tue, Mar 8, 2011 at 7:26 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> On Mon, Mar 07, 2011 at 03:05:43PM -0800, akpm@...ux-foundation.org wrote:
>> Add a proc_dointvec_unsigned() sysctl handler for positive value cases.
>
>> --- a/kernel/sysctl.c~sysctl-add-proc_dointvec_unsigned-handler
>> +++ a/kernel/sysctl.c
>
>> +int proc_dointvec_unsigned(struct ctl_table *table, int write,
>> +               void __user *buffer, size_t *lenp, loff_t *ppos)
>> +{
>> +     struct do_proc_dointvec_minmax_conv_param param = {
>> +             .min = &zero,
>> +     };
>> +     return do_proc_dointvec(table, write, buffer, lenp, ppos,
>> +                             do_proc_dointvec_minmax_conv, &param);
>> +}
>
> This silently ignored max value in .extra2 .

Hi,

Good cache, should set .max = NULL here

Thanks, will update this patch.

-- 
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/