linux-kernel - [tip:x86/urgent] x86: Don't check for BIOS corruption in first 64K when there's no need to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-acc45cf678528c8ebe20e9bb8b51c2ea1022e6d3@git.kernel.org>
Date:	Wed, 9 Mar 2011 11:22:17 GMT
From:	tip-bot for Naga Chumbalkar <nagananda.chumbalkar@...com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	stable@...nel.org, nagananda.chumbalkar@...com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:x86/urgent] x86: Don't check for BIOS corruption in first 64K when there's no need to

Commit-ID:  acc45cf678528c8ebe20e9bb8b51c2ea1022e6d3
Gitweb:     http://git.kernel.org/tip/acc45cf678528c8ebe20e9bb8b51c2ea1022e6d3
Author:     Naga Chumbalkar <nagananda.chumbalkar@...com>
AuthorDate: Fri, 25 Feb 2011 20:31:55 +0000
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Wed, 9 Mar 2011 10:34:21 +0100

x86: Don't check for BIOS corruption in first 64K when there's no need to

Due to commit 781c5a67f152c17c3e4a9ed9647f8c0be6ea5ae9 it is
likely that the number of areas to scan for BIOS corruption is 0
 -- especially when the first 64K is already reserved
(X86_RESERVE_LOW is 64K by default).

If that's the case then don't set up the scan.

Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@...com>
Cc: <stable@...nel.org>
LKML-Reference: <20110225202838.2229.71011.sendpatchset@...umbalkar.americas.hpqcorp.net>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/check.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
index 13a3891..bfd59ea 100644
--- a/arch/x86/kernel/check.c
+++ b/arch/x86/kernel/check.c
@@ -106,8 +106,8 @@ void __init setup_bios_corruption_check(void)
 		addr += size;
 	}
 
-	printk(KERN_INFO "Scanning %d areas for low memory corruption\n",
-	       num_scan_areas);
+	if (num_scan_areas)
+		printk(KERN_INFO "Scanning %d areas for low memory " "corruption\n", num_scan_areas);
 }
 
 
@@ -143,12 +143,12 @@ static void check_corruption(struct work_struct *dummy)
 {
 	check_for_bios_corruption();
 	schedule_delayed_work(&bios_check_work,
-		round_jiffies_relative(corruption_check_period*HZ)); 
+		round_jiffies_relative(corruption_check_period*HZ));
 }
 
 static int start_periodic_check_for_corruption(void)
 {
-	if (!memory_corruption_check || corruption_check_period == 0)
+	if (!num_scan_areas || !memory_corruption_check || corruption_check_period == 0)
 		return 0;
 
 	printk(KERN_INFO "Scanning for low memory corruption every %d seconds\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/