linux-kernel - Re: [PATCH] add missing guest clock update removed by e48672fa25e879f7ae21785c7efd187738139593

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110309193003.GB1762@pcnci.linuxbox.cz>
Date:	Wed, 9 Mar 2011 20:30:03 +0100
From:	Nikola Ciprich <extmaillist@...uxbox.cz>
To:	Zachary Amsden <zamsden@...hat.com>
Cc:	KVM list <kvm@...r.kernel.org>,
	Linux kernel list <linux-kernel@...r.kernel.org>,
	nikola.ciprich@...uxbox.cz, Avi Kivity <avi@...hat.com>,
	Glauber Costa <glommer@...hat.com>
Subject: Re: [PATCH] add missing guest clock update removed by
	e48672fa25e879f7ae21785c7efd187738139593

> Can you try moving the kvm_make_request() inside the if conditional and  
> see if it that also fixes it?

yes, changing to:
if (unlikely(vcpu->cpu != cpu) || check_tsc_unstable()) {
	kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
	/* Make sure TSC doesn't go backwards */
	s64 tsc_delta = !vcpu->arch.last_host_tsc ? 0 :

is also OK.

what about changing:
if (check_tsc_unstable()) {
	kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta);                                                                                                               
	vcpu->arch.tsc_catchup = 1;
	kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
}                                                                                                                                                                       

to:

if (check_tsc_unstable()) {
	kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta);                                                                                                               
	vcpu->arch.tsc_catchup = 1;
}                                                                                                                                                                       
kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);

this fixes thinks for me as well..
n.
?


> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@...uxbox.cz
-------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/