| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTi==5jKHwTEhh1xE7_7-a7JHbaNWOdOKHFFdz0Wc@mail.gmail.com>
Date: Wed, 9 Mar 2011 13:21:28 -0800
From: Vinay Sawal <vinaysawal@...il.com>
To: Belisko Marek <marek.belisko@...il.com>
Cc: gregkh@...e.de, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
On Wed, Mar 9, 2011 at 12:55 PM, Belisko Marek <marek.belisko@...il.com> wrote:
> On Wed, Mar 9, 2011 at 9:50 PM, Vinay Sawal <vinaysawal@...il.com> wrote:
>> Fixed all issues reported by checkpatch script on this file.
>>
>> Signed-off-by: Vinay Sawal <vinaysawal@...il.com>
>> ---
>> drivers/staging/bcm/Bcmnet.c | 51 +++++++++++++++++++++++++++++------------
>> 1 files changed, 36 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
>> index a6ce239..4e38a76 100644
>> --- a/drivers/staging/bcm/Bcmnet.c
>> +++ b/drivers/staging/bcm/Bcmnet.c
>> @@ -1,3 +1,23 @@
>> +/*
>> + bcm/Bcmnet.c
>> + Bcm network driver
>> +
>> + This program is free software; you can redistribute it and/or modify
>> + it under the terms of the GNU General Public License as published by
>> + the Free Software Foundation; either version 2 of the License, or
>> + (at your option) any later version.
>> +
>> + This program is distributed in the hope that it will be useful,
>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + GNU General Public License for more details.
>> +
>> + You should have received a copy of the GNU General Public License
>> + along with this program; if not, write to the Free Software
>> + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>> +
>> +*/
> NOt sure if I miss somethoing but why you add header
> if you fix only checkpatch.pl fixes? I don't know that
> checkpatch.pl complain about missing header file?
You're correct. The script checkpatch didn't complain about the
missing license header. But since the license header was missing, I
added it. I should have listed it in the patch comments.
Isn't it a requirement to have the GPL license header in every file ?
If true, maybe the script can be enhanced to check for missing license
header.
Thanks,
Vinay
>> +
>> #include "headers.h"
>>
>> struct net_device *gblpnetdev;
>> @@ -8,7 +28,7 @@ static INT bcm_open(struct net_device *dev)
>>
>> if (Adapter->fw_download_done == FALSE) {
>> pr_notice(PFX "%s: link up failed (download in progress)\n",
>> - dev->name);
>> + dev->name);
>> return -EBUSY;
>> }
>>
>> @@ -50,7 +70,7 @@ static u16 bcm_select_queue(struct net_device *dev, struct sk_buff *skb)
>> * Description - This is the main transmit function for our virtual
>> * interface(eth0). It handles the ARP packets. It
>> * clones this packet and then Queue it to a suitable
>> -* Queue. Then calls the transmit_packet().
>> +* Queue. Then calls the transmit_packet().
>> *
>> * Parameter - skb - Pointer to the socket buffer structure
>> * dev - Pointer to the virtual net device structure
>> @@ -110,13 +130,13 @@ static netdev_tx_t bcm_transmit(struct sk_buff *skb, struct net_device *dev)
>> Register other driver entry points with the kernel
>> */
>> static const struct net_device_ops bcmNetDevOps = {
>> - .ndo_open = bcm_open,
>> - .ndo_stop = bcm_close,
>> - .ndo_start_xmit = bcm_transmit,
>> - .ndo_change_mtu = eth_change_mtu,
>> - .ndo_set_mac_address = eth_mac_addr,
>> - .ndo_validate_addr = eth_validate_addr,
>> - .ndo_select_queue = bcm_select_queue,
>> + .ndo_open = bcm_open,
>> + .ndo_stop = bcm_close,
>> + .ndo_start_xmit = bcm_transmit,
>> + .ndo_change_mtu = eth_change_mtu,
>> + .ndo_set_mac_address = eth_mac_addr,
>> + .ndo_validate_addr = eth_validate_addr,
>> + .ndo_select_queue = bcm_select_queue,
>> };
>>
>> static struct device_type wimax_type = {
>> @@ -138,7 +158,8 @@ static int bcm_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
>> return 0;
>> }
>>
>> -static void bcm_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
>> +static void bcm_get_drvinfo(struct net_device *dev,
>> + struct ethtool_drvinfo *info)
>> {
>> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>> PS_INTERFACE_ADAPTER psIntfAdapter = Adapter->pvInterfaceAdapter;
>> @@ -160,14 +181,14 @@ static u32 bcm_get_link(struct net_device *dev)
>> return Adapter->LinkUpStatus;
>> }
>>
>> -static u32 bcm_get_msglevel (struct net_device *dev)
>> +static u32 bcm_get_msglevel(struct net_device *dev)
>> {
>> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>>
>> return Adapter->msg_enable;
>> }
>>
>> -static void bcm_set_msglevel (struct net_device *dev, u32 level)
>> +static void bcm_set_msglevel(struct net_device *dev, u32 level)
>> {
>> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>>
>> @@ -177,7 +198,7 @@ static void bcm_set_msglevel (struct net_device *dev, u32 level)
>> static const struct ethtool_ops bcm_ethtool_ops = {
>> .get_settings = bcm_get_settings,
>> .get_drvinfo = bcm_get_drvinfo,
>> - .get_link = bcm_get_link,
>> + .get_link = bcm_get_link,
>> .get_msglevel = bcm_get_msglevel,
>> .set_msglevel = bcm_set_msglevel,
>> };
>> @@ -206,7 +227,7 @@ int register_networkdev(PMINI_ADAPTER Adapter)
>> if (result != STATUS_SUCCESS) {
>> dev_err(&udev->dev,
>> PFX "Error in Reading the mac Address: %d", result);
>> - return -EIO;
>> + return -EIO;
>> }
>>
>> result = register_netdev(net);
>> @@ -233,6 +254,6 @@ void unregister_networkdev(PMINI_ADAPTER Adapter)
>> if (netif_msg_probe(Adapter))
>> dev_info(&udev->dev, PFX "%s: unregister usb-%s%s\n",
>> net->name, xdev->bus->bus_name, xdev->devpath);
>> -
>> +
>> unregister_netdev(Adapter->dev);
>> }
>> --
>> 1.6.2.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
> thanks,
>
> marek
>
> --
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
>
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> icq: 290551086
> web: http://open-nandra.com
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists