linux-kernel - Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Mar 2011 13:26:43 -0800
From:	Greg KH <gregkh@...e.de>
To:	Vinay Sawal <vinaysawal@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

On Wed, Mar 09, 2011 at 12:50:01PM -0800, Vinay Sawal wrote:
> Fixed all issues reported by checkpatch script on this file.
> 
> Signed-off-by: Vinay Sawal <vinaysawal@...il.com>
> ---
>  drivers/staging/bcm/Bcmnet.c |   51 +++++++++++++++++++++++++++++------------
>  1 files changed, 36 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
> index a6ce239..4e38a76 100644
> --- a/drivers/staging/bcm/Bcmnet.c
> +++ b/drivers/staging/bcm/Bcmnet.c
> @@ -1,3 +1,23 @@
> +/*
> +    bcm/Bcmnet.c
> +    Bcm network driver
> +
> +    This program is free software; you can redistribute it and/or modify
> +    it under the terms of the GNU General Public License as published by
> +    the Free Software Foundation; either version 2 of the License, or
> +    (at your option) any later version.

Why "or any later version"?  Are you allowed to relicense the code here?

> +
> +    This program is distributed in the hope that it will be useful,
> +    but WITHOUT ANY WARRANTY; without even the implied warranty of
> +    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +    GNU General Public License for more details.
> +
> +    You should have received a copy of the GNU General Public License
> +    along with this program; if not, write to the Free Software
> +    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.

Are you willing to track the office movements of the FSF for the next 40
years and send patches updating the address?  If not, NEVER, include
this paragraph, it's pointless.

Anyway, as others stated, this is not acceptable for a "fix checkpatch
warnings" type of patch, please redo it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/