linux-kernel - Re: [PATCH 00/21] Coding style and minor changes in ft1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 Mar 2011 16:00:22 -0800
From:	Greg KH <greg@...ah.com>
To:	Marek Belisko <marek.belisko@...n-nandra.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/21] Coding style and minor changes in ft1000_hw.

On Mon, Mar 07, 2011 at 09:21:05AM +0100, Marek Belisko wrote:
> Marek Belisko (21):
>   staging: ft1000: Replace camelcase CardSendCommand function name.
>   staging: ft1000: Fix coding style in card_send_command function.
>   staging: ft1000: Fix coding style in dsp_reload function.
>   staging: ft1000: Fix coding style in ft1000_reset_asic function.
>   staging: ft1000: Fix coding style in ft1000_reset_card function.
>   staging: ft1000: Fix identation in ftnet_ops struct.
>   staging: ft1000: Fix coding style in init_ft1000_netdev function.
>   staging: ft1000: Change return value for init_ft1000_netdev function.
>   staging: ft1000: Fix coding style in reg_ft1000_netdev function.
>   staging: ft1000: Fix coding style in ft1000_reset function.
>   staging: ft1000: Fix coding style in ft1000_usb_transmit_complete
>     function.
>   staging: ft1000: Fix coding style in ft1000_copy_down_pkt function.
>   staging: ft1000: Fix coding style in ft1000_start_xmit function.
>   staging: ft1000: Fix coding style in ft1000_submit_rx_urb function.
>   staging: ft1000: Fix coding style in ft1000_copy_up_pkt function.
>   staging: ft1000: Fix coding style in ft1000_open function.
>   staging: ft1000: Fix coding style in ft1000_close function.
>   staging: ft1000: Fix coding style in ft1000_chkcard function.
>   staging: ft1000: Fix coding style in ft1000_receive_cmd function.
>   staging: ft1000: Fix coding style in ft1000_dsp_prov function.
>   staging: ft1000: Fix coding style in ft1000_proc_drvmsg function.
> 
>  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c |    6 +-
>  drivers/staging/ft1000/ft1000-usb/ft1000_hw.c    | 1724 +++++++++++-----------
>  drivers/staging/ft1000/ft1000-usb/ft1000_usb.h   |    4 +-

After applying this series, I get the following build error:
	drivers/staging/ft1000/ft1000-usb/ft1000_hw.c: In function ‘ft1000_proc_drvmsg’:
	drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:1825:5: error: implicit declaration of function ‘CardSendCommand’

So I've dropped the whole series.

Care to try it again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/