linux-kernel - Re: [PATCH 07/10] perf script: Move printing of 'common' data from print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D78158F.6010403@cisco.com>
Date:	Wed, 09 Mar 2011 17:04:31 -0700
From:	David Ahern <daahern@...co.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 07/10] perf script: Move printing of 'common' data from
 print_event and rename



On 03/09/11 16:50, Frederic Weisbecker wrote:

>> +++ b/tools/perf/util/trace-event-parse.c
>> @@ -2648,63 +2648,8 @@ static void print_lat_fmt(void *data, int size __unused)
>>  		printf("%d", lock_depth);
>>  }
>>  
>> -/* taken from Linux, written by Frederic Weisbecker */
>> -static void print_graph_cpu(int cpu)
>> -{
>> -	int i;
>> -	int log10_this = log10_cpu(cpu);
>> -	int log10_all = log10_cpu(cpus);
>> -
>> -
>> -	/*
>> -	 * Start with a space character - to make it stand out
>> -	 * to the right a bit when trace output is pasted into
>> -	 * email:
>> -	 */
>> -	printf(" ");
>> -
>> -	/*
>> -	 * Tricky - we space the CPU field according to the max
>> -	 * number of online CPUs. On a 2-cpu system it would take
>> -	 * a maximum of 1 digit - on a 128 cpu system it would
>> -	 * take up to 3 digits:
>> -	 */
>> -	for (i = 0; i < log10_all - log10_this; i++)
>> -		printf(" ");
>> -
>> -	printf("%d) ", cpu);
>> -}
> 
> So, we indeed don't use the function graph tracer with perf yet.
> But there are fair chances we will in the future.
> 
> So if we remove such code, I would prefer this to be made as
> a seperate commit. Something we can easily retrieve and revert
> in the future.

Once the references to the functions are removed, compile fails --
functions defined without a user.

I left the cpu arg into print_trace_event to avoid having to delete even
more code because of that.

David


> 
> Other than that and the callchain bug, the whole series looks
> pretty good now.
> 
> Thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/