linux-kernel - Re: [PATCH n_gsm] GSM Mux in non-transparent mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D7A24CF.9070805@eukrea.com>
Date:	Fri, 11 Mar 2011 14:34:07 +0100
From:	Eric Bénard <eric@...rea.com>
To:	Mário Isidoro <marioisidoro@...il.com>
CC:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH n_gsm] GSM Mux in non-transparent mode

Hi Mário,

On 10/03/2011 03:39, Mário Isidoro wrote:
> @@ -2661,9 +2725,12 @@ static int gsmtty_tiocmset(struct tty_struct
> *tty, struct file *filp,
>   	struct gsm_dlci *dlci = tty->driver_data;
>   	unsigned int modem_tx = dlci->modem_tx;
>
> -	modem_tx &= clear;
> +	modem_tx &= ~clear;
>   	modem_tx |= set;
>
good catch : this fix (and only this one in your patch) makes Telit modems 
work realiable here with ppp (which was failing before).
Tested on GC864-QUAD-V2, UC864-E and UC864-WD

Thanks !

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/