linux-kernel - Re: [PATCH n_gsm] GSM Mux in non-transparent mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Mar 2011 15:27:41 +0000
From:	Mário Isidoro <marioisidoro@...il.com>
To:	Eric Bénard <eric@...rea.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH n_gsm] GSM Mux in non-transparent mode

Hi Eric
My GE863-Pro^3 works well without it, however, without it the control
signals from the computer side do not seem to work correctly.

>From my tests, without the patch, the value in modem_tx will never
change when we send TIOCMSET commands.

By the way, can you confirm if your Telit modems respect the EA bit on
the MSC frame ? 

Thank you,

Mário Isidoro

On Fri, 2011-03-11 at 14:34 +0100, Eric Bénard wrote:
> Hi Mário,
> 
> On 10/03/2011 03:39, Mário Isidoro wrote:
> > @@ -2661,9 +2725,12 @@ static int gsmtty_tiocmset(struct tty_struct
> > *tty, struct file *filp,
> >   	struct gsm_dlci *dlci = tty->driver_data;
> >   	unsigned int modem_tx = dlci->modem_tx;
> >
> > -	modem_tx &= clear;
> > +	modem_tx &= ~clear;
> >   	modem_tx |= set;
> >
> good catch : this fix (and only this one in your patch) makes Telit modems 
> work realiable here with ppp (which was failing before).
> Tested on GC864-QUAD-V2, UC864-E and UC864-WD
> 
> Thanks !
> 
> Eric


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/