[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTi=Jo_bPiZDg0uYgN+scH1m=G59GQzbuMTZeeFyO@mail.gmail.com>
Date: Fri, 11 Mar 2011 21:35:04 -0800
From: Justin TerAvest <teravest@...gle.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: jaxboe@...ionio.com, vgoyal@...hat.com, ctalbott@...gle.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add unaccounted time to timeslice_used.
On Fri, Mar 11, 2011 at 8:17 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri, Mar 11, 2011 at 01:06:12PM -0800, Justin TerAvest wrote:
>> There are two kind of times that tasks are not charged for: the first
>> seek and the extra time slice used over the allocated timeslice. Both
>> of these exported as a new unaccounted_time stat.
>>
>> I think it would be good to have this reported in 'time' as well, but
>> that is probably a separate discussion.
>>
>> Signed-off-by: Justin TerAvest <teravest@...gle.com>
>> ---
>> block/blk-cgroup.c | 16 +++++++++++++++-
>> block/blk-cgroup.h | 12 ++++++++++--
>> block/cfq-iosched.c | 21 +++++++++++++--------
>> block/cfq.h | 6 +++---
>> 4 files changed, 41 insertions(+), 14 deletions(-)
>
> Hi! Just an FYI, could you add what subsystem you are changing into the
> subject. Like:
>
> [PATCH] block: Add unaccounted time to timeslice_used
>
> Otherwise, the subject looks like it's modifying the kernel internal time
> source.
Sorry about that. I'll be more careful in the future.
Thanks,
Justin
>
> Thanks,
>
> -- Steve
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists