linux-kernel - Re: [PATCH 2/8] x86: Use syscore_ops instead of sysdev classes and sysdevs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201103131607.59855.rjw@sisk.pl>
Date:	Sun, 13 Mar 2011 16:07:59 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Len Brown <lenb@...nel.org>,
	Greg KH <gregkh@...e.de>, Kay Sievers <kay.sievers@...e.de>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>, mingo@...hat.com,
	Dave Jones <davej@...hat.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH 2/8] x86: Use syscore_ops instead of sysdev classes and sysdevs

On Sunday, March 13, 2011, Thomas Gleixner wrote:
> On Sat, 12 Mar 2011, Rafael J. Wysocki wrote:
> > -static int lapic_resume(struct sys_device *dev)
> > +static void lapic_resume(void)
> >  {
> >  	unsigned int l, h;
> >  	unsigned long flags;
> > @@ -2083,7 +2083,7 @@ static int lapic_resume(struct sys_devic
> >  	struct IO_APIC_route_entry **ioapic_entries = NULL;
> >  
> >  	if (!apic_pm_state.active)
> > -		return 0;
> > +		return;
> >  
> >  	local_irq_save(flags);
> 
> That want's the following on top:
> 
> @@ -2079,8 +2079,7 @@ static void lapic_resume(void)
>  {
>  	unsigned int l, h;
>  	unsigned long flags;
> -	int maxlvt;
> -	int ret = 0;
> +	int maxlvt, ret;
>  	struct IO_APIC_route_entry **ioapic_entries = NULL;
>  
>  	if (!apic_pm_state.active)
> @@ -2091,7 +2090,6 @@ static void lapic_resume(void)
>  		ioapic_entries = alloc_ioapic_entries();
>  		if (!ioapic_entries) {
>  			WARN(1, "Alloc ioapic_entries in lapic resume failed.");
> -			ret = -ENOMEM;
>  			goto restore;
>  		}

Right, I'll fold it into the final version of the patch.

> Otherwise, Reviewed-by: Thomas Gleixner <tglx@...utronix.de>

Thanks!

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/