linux-kernel - Re: [PATCH] fs, coda: Fix compile warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110314153413.a8ec2093.akpm@linux-foundation.org>
Date:	Mon, 14 Mar 2011 15:34:13 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	Jan Harkes <jaharkes@...cmu.edu>,
	LKML <linux-kernel@...r.kernel.org>, coda@...cmu.edu,
	codalist@...EMANN.coda.cs.cmu.edu
Subject: Re: [PATCH] fs, coda: Fix compile warning when CONFIG_SYSCTL=n.

On Sun, 13 Mar 2011 21:48:23 +0600
Rakib Mullick <rakib.mullick@...il.com> wrote:

> When CONFIG_SYSCTL=n, we get the following warning:
> 
> fs/coda/sysctl.c:18: warning: ___coda_table___ defined but not used
> 
> Following patches fixes the above warning by making sure coda_table
> and it's callee
> function are in the same context. It also cleans up the code by
> removing extra #ifdef.
> 
> ...
>
> --- a/fs/coda/sysctl.c
> +++ b/fs/coda/sysctl.c
>
> ...
>
> +#else
> +
> +#define	coda_sysctl_init()		do { }  while (0);
> +#define	coda_sysctl_clean()		do { }	while (0);
> +
> +#endif

These do/while stubs should not have the trailing ";" - adding them
will cause breakage in some calling scenarios.

It is much better to implement such stubs in C rather than as macros.

But these stubs can't be doing anything useful anyway: they appear at
the end of a .c file which wasn't #included by anything.  Therefore:

--- a/fs/coda/sysctl.c~fs-coda-fix-compile-warning-when-config_sysctl=n-fix
+++ a/fs/coda/sysctl.c
@@ -61,9 +61,4 @@ void coda_sysctl_clean(void)
 		fs_table_header = NULL;
 	}
 }
-#else
-
-#define	coda_sysctl_init()		do { }  while (0);
-#define	coda_sysctl_clean()		do { }	while (0);
-
 #endif
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/