linux-kernel - Re: [RFT][PATCH] PCI / ACPI: Do not require MSI support for PCIe native features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201103150100.17501.rjw@sisk.pl>
Date:	Tue, 15 Mar 2011 01:00:17 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	ACPI Devel Mailing List <linux-acpi@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [RFT][PATCH] PCI / ACPI: Do not require MSI support for PCIe native features

On Tuesday, March 15, 2011, Sarah Sharp wrote:
> On Mon, Mar 14, 2011 at 09:37:41PM +0100, Rafael J. Wysocki wrote:
> > On Monday, March 14, 2011, Sarah Sharp wrote:
> > > On Mon, Mar 14, 2011 at 09:02:11PM +0100, Rafael J. Wysocki wrote:
> > > > On Monday, March 14, 2011, Sarah Sharp wrote:
> > > > > Hi Rafael,
> > > > > 
> > > > > I applied this patch, on top of this patch:
> > > > > PCI/ACPI: Report ASPM support to BIOS if not disabled from command line
> > > > > 
> > > > > Unfortunately, the Express Card still doesn't show up.  The trace looks
> > > > > slightly different, but the irq still gets disabled.  dmesg is attached.
> > > > 
> > > > Hmm.  It looks like, for some reason, the check against
> > > > pcie_aspm_support_enabled() returns false on your system.  Do you have
> > > > ASPM enabled in .config?
> > > 
> > > My .config is attached.  Looks like CONFIG_PCIEASPM=y.
> > 
> > Does it help if you replace "pcie_aspm_support_enabled()" with "true" in
> > drivers/acpi/pci_root.c:acpi_pci_root_add() ?
> 
> No, it doesn't.  dmesg is attached.

Well, I must admit I have no idea what the problem is.  OK, in addition to the
above changes, please replace the "pci_ext_cfg_avail(root->bus->self)" in the
same file with "true" and see if _that_ helps.

If it doesn't, please send me your drivers/acpi/pci_root.c after all of the
above changes.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/