[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.00.1103151206140.9668@cl320.eecs.utk.edu>
Date: Tue, 15 Mar 2011 12:09:18 -0400 (EDT)
From: Vince Weaver <vweaver1@...s.utk.edu>
To: Peter Zijlstra <a.p.zijlstra@...llo.nl>
cc: Arnaldo Carvalho de Melo <acme@...hat.com>,
linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
Ingo Molnar <mingo@...e.hu>,
Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf: Fix tear-down of inherited group events
On Tue, 15 Mar 2011, Peter Zijlstra wrote:
> Subject: perf: Fix tear-down of inherited group events
> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Date: Tue Mar 15 14:37:10 CET 2011
>
> When destroying inherited events, we need to destroy groups too,
> otherwise the event iteration in perf_event_exit_task_context() will
> miss group siblings and we leak events with all the consequences.
Thanks for the fix! I can verify that when applied against current
linus-git kernel that my original test case no longer leaks memory.
I've also run the full PAPI regression tests, plus the BLAS/PAPI benchmark
code that originally showed the problem and everything checks out fine.
It's a shame this fix didn't make it in before 2.6.38.
Tested-by: Vince Weaver <vweaver1@...s.utk.edu>
Vince
vweaver1@...s.utk.edu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists