linux-kernel - Re: [PATCH] perf: Fix tear-down of inherited group events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300207283.2203.213.camel@twins>
Date:	Tue, 15 Mar 2011 17:41:23 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Vince Weaver <vweaver1@...s.utk.edu>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...e.hu>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf: Fix tear-down of inherited group events

On Tue, 2011-03-15 at 12:09 -0400, Vince Weaver wrote:
> On Tue, 15 Mar 2011, Peter Zijlstra wrote:
> 
> > Subject: perf: Fix tear-down of inherited group events
> > From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Date: Tue Mar 15 14:37:10 CET 2011
> > 
> > When destroying inherited events, we need to destroy groups too,
> > otherwise the event iteration in perf_event_exit_task_context() will
> > miss group siblings and we leak events with all the consequences.
> 
> Thanks for the fix!  I can verify that when applied against current 
> linus-git kernel that my original test case no longer leaks memory.
> 
> I've also run the full PAPI regression tests, plus the BLAS/PAPI benchmark 
> code that originally showed the problem and everything checks out fine.
> 
> It's a shame this fix didn't make it in before 2.6.38.

It sure is, sadly there's still only 24h in a day, less if you consider
this .jp earthquake speeding up our planets spin :-)

> Tested-by: Vince Weaver <vweaver1@...s.utk.edu>

Thanks Vince!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/