linux-kernel - Re: [tip:perf/core] perf probe: Clean up probe_point_lazy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300262357.2250.58.camel@laptop>
Date:	Wed, 16 Mar 2011 08:59:17 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	mingo@...hat.com, hpa@...or.com, acme@...hat.com,
	linux-kernel@...r.kernel.org, fweisbec@...il.com,
	masami.hiramatsu.pt@...achi.com, tglx@...utronix.de, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] perf probe: Clean up probe_point_lazy_walker()
 return value

On Tue, 2011-03-15 at 23:18 +0000, tip-bot for Ingo Molnar wrote:

> perf probe: Clean up probe_point_lazy_walker() return value

> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -1328,7 +1328,7 @@ static int probe_point_lazy_walker(const char *fname, int lineno,
>  	 * Continue if no error, because the lazy pattern will match
>  	 * to other lines
>  	 */
> -	return ret < 0 ?: 0;
> +	return ret < 0 ? ret : 0;
>  }

It is a slight change in semantics though, the return value will now be
negative instead of 1. If its used as a boolean that's fine, but still.

I'd have changed it to:

  return ret < 0;

Which is identical to the previous statement.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/