linux-kernel - Re: [PATCH] fs/9p: Use updated offset for writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874o73ij6t.fsf@linux.vnet.ibm.com>
Date:	Wed, 16 Mar 2011 13:35:46 +0530
From:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	"M. Mohan Kumar" <mohan@...ibm.com>,
	v9fs-developer@...ts.sourceforge.net
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/9p: Use updated offset for writing

On Wed, 16 Mar 2011 10:39:16 +0530, "M. Mohan Kumar" <mohan@...ibm.com> wrote:
> Use the updated offset given by generic_write_checks. Without this fix,
> even if a file is opened in O_APPEND mode, data will be written at current
> file position instead of end of file.
> 
> Signed-off-by: M. Mohan Kumar <mohan@...ibm.com>
> ---
>  fs/9p/vfs_file.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 6997eb6..51049cd 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -510,7 +510,7 @@ v9fs_file_write(struct file *filp, const char __user * data,
> 
>  	return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
>  					filp->private_data,
> -					data, count, offset, 1);
> +					data, count, &origin, 1);
>  out:
>  	return retval;
>  }

You should also update offset on success.

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/