linux-kernel - Re: [PATCH] AB8500 GPIO : Driver for 42 AB8500 GPIO pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110317191132.GA12824@angua.secretlab.ca>
Date:	Thu, 17 Mar 2011 13:11:32 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Bibek BASU <bibek.basu@...ricsson.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] AB8500 GPIO : Driver for 42 AB8500 GPIO pins

On Tue, Mar 15, 2011 at 03:51:09PM +0100, Linus Walleij wrote:
> On Tue, Mar 15, 2011 at 3:33 PM, Grant Likely <grant.likely@...retlab.ca> wrote:
> 
> > Ping me *after* Russell's tree gets merged and I'll pick it up.  I
> > don't want to mess about with apply-order breakage.
> 
> This driver does not depend on anything from Russells tree
> or any other tree for that matter... It's a clean merge.

  CC      drivers/gpio/ab8500-gpio.o
  /home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c: In function 'ab8500_gpio_probe':
  /home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: 'MOP500_AB8500_VIR_GPIO_IRQ_BASE' undeclared (first use in this function)
  /home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: (Each undeclared identifier is reported only once
  /home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: for each function it appears in.)
  make[2]: *** [drivers/gpio/ab8500-gpio.o] Error 1
  make[1]: *** [drivers/gpio/ab8500-gpio.o] Error 2
  make: *** [sub-make] Error 2

and:

$ git grep MOP500_AB8500_VIR_GPIO_IRQ_BASE origin
$ 

Looks like I cannot merge this yet.

BTW, why is this driver hardcoding the gpio irq base address instead
of retrieving it from the platform data?

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/