linux-kernel - Re: [PATCH]: SMBIOS: Add initial code and export version via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D825D32.1080309@redhat.com>
Date:	Thu, 17 Mar 2011 15:12:50 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	linux-kernel@...r.kernel.org, dzickus@...hat.com,
	Greg KH <gregkh@...e.de>
Subject: Re: [PATCH]: SMBIOS: Add initial code and export version via sysfs



On 03/17/2011 03:09 PM, Alan Cox wrote:
>> +static struct class smbios_class = {
>> +	.name = "smbios",
>> +	.dev_release = (void(*)(struct device *)) kfree,
>> +};
>>     
> I thought the policy was no new classes- Greg ?
>   

Greg, eventually the SMBIOS code could replace the mixed DMI/SMBIOS code
we have right now.  If there is a "no new classes" policy, could you
give me an idea of what I should do/use instead?  The DMI stuff is
currently in its own class ...

>   
>> +		smbios_iounmap(buf, sizeof(*smbios_step));
>> +		printk(KERN_INFO "SMBIOS: Invalid STEP table checksum = %u\n",
>> +		       chksum1);
>>     
> Surely this isn't INFO ?
>
>   

Good point :)  I can certainly make that higher or a WARN_ON in the next
version.

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/