linux-kernel - Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110318142618.GA3142@gmail.com>
Date:	Fri, 18 Mar 2011 22:26:22 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	john.stultz@...aro.org, linux-kernel@...r.kernel.org,
	stable@...nel.org, rtc-linux@...glegroups.com, a.zummo@...ertech.it
Subject: Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote:
> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
> the end leading to the build warning:
> 	drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
> 	drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
Hi Mike,
   I am sure we should give a return-value
but whether it is '0'? Maybe it should return
other value.
   Can you give some explanations for yours.

   Thanks.
   Best Regards.
   Harry Wei.
> 
> CC: stable@...nel.org
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  drivers/rtc/rtc-bfin.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
> index 17971d9..0e61e2d 100644
> --- a/drivers/rtc/rtc-bfin.c
> +++ b/drivers/rtc/rtc-bfin.c
> @@ -276,6 +276,8 @@ static int bfin_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
>  		bfin_rtc_int_set_alarm(rtc);
>  	else
>  		bfin_rtc_int_clear(~(RTC_ISTAT_ALARM | RTC_ISTAT_ALARM_DAY));
> +
> +	return 0;
>  }
>  
>  static int bfin_rtc_read_time(struct device *dev, struct rtc_time *tm)
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/