linux-kernel - Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinExKgnaSMceMhMkAD8rF9RM4UM363WjgtfmZFt@mail.gmail.com>
Date:	Fri, 18 Mar 2011 13:52:26 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Harry Wei <jiaweiwei.xiyou@...il.com>
Cc:	john.stultz@...aro.org, linux-kernel@...r.kernel.org,
	stable@...nel.org, rtc-linux@...glegroups.com, a.zummo@...ertech.it
Subject: Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func

On Fri, Mar 18, 2011 at 10:26, Harry Wei wrote:
> On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote:
>> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
>> the end leading to the build warning:
>>       drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
>>       drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
>
>   I am sure we should give a return-value
> but whether it is '0'? Maybe it should return
> other value.
>   Can you give some explanations for yours.

read the interface.c code ... this func returns 0 on "success".  i
dont know what other possible value this could return.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/