linux-kernel - [build failure] Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110321122111.GA17237@elte.hu>
Date:	Mon, 21 Mar 2011 13:21:11 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	James Bottomley <James.Bottomley@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: [build failure] Re: [GIT PULL] First round of SCSI updates for
 2.6.38 merge window


* James Bottomley <James.Bottomley@...e.de> wrote:

> This represents the usual round of driver updates (fcoe, lpfc, qla2xxx,
> zfcp, bnx2i, mpt2sas, megaraid_sas, iscsi, cxgbi and hpsa) plus one new
> driver (bnx2fc) and as a bonus we move libsas from the old libata eh to
> the new one paving the way for junking the old one (once we can get ipr
> converted).

The new bnx2fc driver does not build with module support disabled:

 drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:17: error: dereferencing pointer to incomplete type
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:28: error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:17: error: dereferencing pointer to incomplete type
 drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:28: error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)

and this build breakage has been reported to you two weeks ago:

 http://lkml.org/lkml/2011/3/2/468

In the future please do not push broken code upstream or put it into 
drivers/staging/scsi/ if it has outstanding problems. I'm using the hack below 
for the time being.

Thanks,

	Ingo

-------------------->
>From dd6fd5ea95cba76a625e13910f35cd967ace7fe4 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Mon, 21 Mar 2011 13:15:51 +0100
Subject: [PATCH] <not for upstream> scsi: Disable the bnx2fc driver for the time being

Does not build with CONFIG_MODULES disabled.
---
 drivers/scsi/bnx2fc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/bnx2fc/Kconfig b/drivers/scsi/bnx2fc/Kconfig
index 6a38080..6a111f0 100644
--- a/drivers/scsi/bnx2fc/Kconfig
+++ b/drivers/scsi/bnx2fc/Kconfig
@@ -1,6 +1,7 @@
 config SCSI_BNX2X_FCOE
 	tristate "Broadcom NetXtreme II FCoE support"
 	depends on PCI
+	depends on BROKEN
 	select NETDEVICES
 	select NETDEV_1000
 	select LIBFC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/