linux-kernel - Re: [patch] vlynq: fix resource size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2011 13:25:48 +0100
From:	Florian Fainelli <florian@...nwrt.org>
To:	Dan Carpenter <error27@...il.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] vlynq: fix resource size calculation

On Saturday 19 March 2011 05:38:13 Dan Carpenter wrote:
> The original code had an off-by-one error so we didn't release the
> entire memory region on remove().
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Acked-by: Florian Fainelli <florian@...nwrt.org>

> 
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index f885c86..1d37553 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -764,7 +764,7 @@ static int vlynq_remove(struct platform_device *pdev)
> 
>  	device_unregister(&dev->dev);
>  	iounmap(dev->local);
> -	release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> +	release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start + 1);
> 
>  	kfree(dev);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/