linux-kernel - Re: [PATCH v3 4/5] hid-multitouch: refactor initialization of ABS_MT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110321135013.GB3363@polaris.bitmath.org>
Date:	Mon, 21 Mar 2011 14:50:13 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] hid-multitouch: refactor initialization of
 ABS_MT_ORIENTATION

On Mon, Mar 21, 2011 at 02:32:16PM +0100, Benjamin Tissoires wrote:
> Hi Henrik,
> 
> On Mon, Mar 21, 2011 at 10:02, Henrik Rydberg <rydberg@...omail.se> wrote:
> > On Fri, Mar 18, 2011 at 02:27:55PM +0100, Benjamin Tissoires wrote:
> >> No semantic changes, it's just easier to read the code.
> >
> > Please augment this commit message.
> 
> How about:
> 
> "The way the input_set_abs_params was called for the new composite
> field ABS_MT_ORIENTATION was not very clear at second reading.
> We can remove the non-necessary call to set_abs and use the simple
> call to input_set_abs_params."

Sure thing. In addition, the old code was setting the hid parameters
for the wrong field, which was odd.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/