| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTimx6YR_ByHDeqyMmSuE659xyRNkaAoOffTp_RgC@mail.gmail.com> Date: Mon, 21 Mar 2011 14:32:16 +0100 From: Benjamin Tissoires <benjamin.tissoires@...c.fr> To: Henrik Rydberg <rydberg@...omail.se> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, Jiri Kosina <jkosina@...e.cz>, Stephane Chatty <chatty@...-enac.fr>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 4/5] hid-multitouch: refactor initialization of ABS_MT_ORIENTATION Hi Henrik, On Mon, Mar 21, 2011 at 10:02, Henrik Rydberg <rydberg@...omail.se> wrote: > On Fri, Mar 18, 2011 at 02:27:55PM +0100, Benjamin Tissoires wrote: >> No semantic changes, it's just easier to read the code. > > Please augment this commit message. How about: "The way the input_set_abs_params was called for the new composite field ABS_MT_ORIENTATION was not very clear at second reading. We can remove the non-necessary call to set_abs and use the simple call to input_set_abs_params." Cheers, Benjamin > >> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...c.fr> >> Reviewed-by: Stéphane Chatty <chatty@...c.fr> >> --- > > Thanks, > Henrik > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists