linux-kernel - Re: [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimFF3pgMMgOcEhYnRm5adgsCL5S6Hjkz+GFcpCT@mail.gmail.com>
Date:	Mon, 21 Mar 2011 20:56:59 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch

Hi Henrik,

thanks a lot for spotting this.
I think the modification is safe, but I'll give a final test tomorrow
against our hardware.

Thanks,
Benjamin

On Mon, Mar 21, 2011 at 20:06, Henrik Rydberg <rydberg@...omail.se> wrote:
> Hi Benjamin,
>
>> I tested it against 3M1968. I'll try to have it again to make more testing.
>> What symptoms do you have?
>
> With the modification below, it works as expected, and you can add
>
>    Reviewed-and-tested-by: Henrik Rydberg <rydberg@...omail.se>
>
> Thanks!
>
> Henrik
>
> ---
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 7684e96..0f5b89f 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -424,6 +424,8 @@ static int mt_event(struct hid_device *hid, struct hid_field *field,
>                        break;
>
>                default:
> +                       if (td->last_field_index && field->index == td->last_field_index)
> +                               break;
>                        /* fallback to the generic hidinput handling */
>                        return 0;
>                }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/