linux-kernel - Re: [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinAPFnHA=MWbb=Yu7U0AXrxHv2-95M=OequsAL7@mail.gmail.com>
Date:	Mon, 21 Mar 2011 11:13:46 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch

On Mon, Mar 21, 2011 at 10:05, Henrik Rydberg <rydberg@...omail.se> wrote:
> Hi Benjamin,
>
> On Fri, Mar 18, 2011 at 02:27:56PM +0100, Benjamin Tissoires wrote:
>> This patch merges the hid-3m-pct driver into hid-multitouch.
>> To keep devices working the same way they used to with hid-3m-pct,
>> we need to add two signal/noise ratios for width and height.
>> We also need to work on width/height to send proper
>> ABS_MT_ORIENTATION flag.
>>
>> Importing 3M into hid-multitouch also solved the bug in which
>> devices handling width and height in their report descriptors
>> did not show ABS_MT_TOUCH_MAJOR and ABS_MT_TOUCH_MINOR.
>>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...c.fr>
>> Reviewed-by: Stéphane Chatty <chatty@...c.fr>
>> ---
>
> The patch _looks_ good, but I have problems getting this to work on a
> 3M2256. What devices were this one tested on so far?

Hi Henrik,

I tested it against 3M1968. I'll try to have it again to make more testing.
What symptoms do you have?

For the current time, I'll redo the commit message of the previous one
and then eventually we can slip this one for the next round.

And many thanks for the review of the patch series.

Cheers,
Benjamin

>
> Henrik
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/