linux-kernel - [origin tree build failure] Re: [PATCH] fs, coda: Fix compile warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Mar 2011 08:54:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	Jan Harkes <jaharkes@...cmu.edu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, coda@...cmu.edu,
	codalist@...a.cs.cmu.edu,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: [origin tree build failure] Re: [PATCH] fs, coda: Fix compile
 warning when CONFIG_SYSCTL=n.


* Rakib Mullick <rakib.mullick@...il.com> wrote:

> When CONFIG_SYSCTL=n, we get the following warning:
> 
> fs/coda/sysctl.c:18: warning: ‘coda_table’ defined but not used
> 
> Following patches fixes the above warning by making sure coda_table
> and it's callee
> function are in the same context. It also cleans up the code by
> removing extra #ifdef.
> 
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
> ---
> 
> diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
> index c6405ce..d9cc2b3 100644
> --- a/fs/coda/sysctl.c
> +++ b/fs/coda/sysctl.c

FYI, the v2 of this patch:

  0bc825d240ab: codafs: fix compile warning when CONFIG_SYSCTL=n

broke the upstream build:

  fs/built-in.o: In function `init_coda':
  psdev.c:(.init.text+0x2549): undefined reference to `coda_sysctl_clean'
  fs/built-in.o: In function `exit_coda':
  psdev.c:(.exit.text+0x1bf): undefined reference to `coda_sysctl_clean'
  fs/built-in.o: In function `init_coda_psdev':
 psdev.c:(.text.unlikely+0x21e1): undefined reference to `coda_sysctl_init'

I don't think the -v2 commit was build-tested with !CONFIG_PROC_SYSCTL && 
CONFIG_CODA_FS=y.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/