linux-kernel - Re: [PATCH] usb: core: Change usb_create_sysfs_intf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.vsuutwfyvgw7ix@mnazarewicz-glaptop>
Date:	Thu, 24 Mar 2011 17:02:10 +0100
From:	"Michal Nazarewicz" <mnazarewicz@...gle.com>
To:	"Alan Stern" <stern@...land.harvard.edu>
Cc:	"Sergey Senozhatsky" <sergey.senozhatsky@...il.com>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"Chris Wright" <chrisw@...s-sol.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: core: Change usb_create_sysfs_intf_files()' return
 type to void

> On Thu, 24 Mar 2011, Michal Nazarewicz wrote:
>> The usb_create_sysfs_intf_files() function always returned zero even
>> if it failed to create sysfs fails.  Since this is a desired behaviour
>> there is no need to return return code at all.  This commit changes
>> function's return type (form int) to void.
[...]
>> The below patch has not been tested (not even compiled), just a quick  
>> scatch.

On Thu, 24 Mar 2011 16:52:36 +0100, Alan Stern wrote:
> If you had compiled it, you would have seen why it's not a good idea to
> remove retval.  :-)

I must be getting blind...  I explicitly checked if device_create_file()
has __must_check attribute but somehow missed it.

> On the other hand, changing the function's return type to void is okay.
> I think the reason it returns int is historical; there used to be a
> failure mode but it got removed.

In that case I can prepare a v2 later today (unless Sergey feels like
doing that).

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/