linux-kernel - Re: [PATCH 2/2] Input: sparse-keymap - report KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1301060403-19229-1-git-send-email-seth.forshee@canonical.com>
Date:	Fri, 25 Mar 2011 08:40:01 -0500
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: sparse-keymap - report KEY_UNKNOWN for unknown scan codes

On Fri, Mar 25, 2011 at 12:35:54AM -0700, Dmitry Torokhov wrote:
> Hi Seth,
> 
> On Wed, Mar 23, 2011 at 04:13:43PM -0500, Seth Forshee wrote:
> >  
> > +	/* Report an unknown key event as a debugging aid */
> > +	unknown_ke.type = KE_KEY;
> > +	unknown_ke.code = code;
> > +	unknown_ke.keycode = KEY_UNKNOWN;
> > +	sparse_keymap_report_entry(dev, &unknown_ke, value, autorelease);
> 
> I think it should not depend on autorelease but always automatically
> release KEY_UNKNOWN.
> 
> Otherwise I think I'll apply both patches.

Great! Here are the patches with that changed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/