linux-kernel - Re: [PATCH 2/2] Input: sparse-keymap - report KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110325073554.GD2590@core.coreip.homeip.net>
Date:	Fri, 25 Mar 2011 00:35:54 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Seth Forshee <seth.forshee@...onical.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: sparse-keymap - report KEY_UNKNOWN for
 unknown scan codes

Hi Seth,

On Wed, Mar 23, 2011 at 04:13:43PM -0500, Seth Forshee wrote:
>  
> +	/* Report an unknown key event as a debugging aid */
> +	unknown_ke.type = KE_KEY;
> +	unknown_ke.code = code;
> +	unknown_ke.keycode = KEY_UNKNOWN;
> +	sparse_keymap_report_entry(dev, &unknown_ke, value, autorelease);

I think it should not depend on autorelease but always automatically
release KEY_UNKNOWN.

Otherwise I think I'll apply both patches.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/