linux-kernel - Re: [PATCH] watchdog: fix nv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D8D44A7.6060605@oracle.com>
Date:	Fri, 25 Mar 2011 18:43:03 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Mike Waychison <mikew@...gle.com>
CC:	lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>,
	Wim Van Sebroeck <wim@...ana.be>,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: fix nv_tco section mismatch

On 03/25/11 16:42, Mike Waychison wrote:
> On Thu, Mar 24, 2011 at 1:32 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
>> Fix section mismatch warning:
>> Mark the called nv_tco_getdevice() as __devinit, just like its caller.
> 
> This looks fine.
> 
> I can't seem to reproduce the warning on my end however, compiling
> this as a built-in nor as a module.  How do I trigger a difference
> between __init and __devinit?

I just used allmodconfig.  But why wouldn't you see a differnence between
__init and __devinit?  They are defined differently in include/linux/init.h,
but maybe on some $arch, those sections are treated differently?

I dunno.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/