linux-kernel - Re: [PATCH,RFC] perf: panic due to inclied cpu context task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301164168.2250.370.camel@laptop>
Date:	Sat, 26 Mar 2011 19:29:28 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH,RFC] perf: panic due to inclied cpu context task_ctx
 value

On Sat, 2011-03-26 at 18:35 +0100, Oleg Nesterov wrote:
> On 03/26, Oleg Nesterov wrote:
> >
> > On 03/26, Peter Zijlstra wrote:
> > >
> > > diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> > > index c75925c..e9e4e35 100644
> > > --- a/kernel/perf_event.c
> > > +++ b/kernel/perf_event.c
> > > @@ -1073,6 +1073,8 @@ event_sched_out(struct perf_event *event,
> > >  	if (!is_software_event(event))
> > >  		cpuctx->active_oncpu--;
> > >  	ctx->nr_active--;
> > > +	if (!ctx->nr_active && cpuctx->task_ctx == ctx)
> > > +		cpuctx->task_ctx = NULL;
> >
> > If we clear cpuctx->task_ctx, we should also clear ctx->is_active.

Right.

> > Otherwise I can't see any problem, but I do not understand this code
> > enough.
> 
> but probably we also need update_context_time().

It looks like event_sched_out() relies on up-to-date ctx->time through
perf_event_time() and most call-paths leading to event_sched_out() do
indeed seem to update the ctx time, all except the move_group branch in
perf_event_open() afaict.

Sadly the reproducer doesn't seem to trigger the issue at all, its still
running on a plain -tip kernel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/