linux-kernel - Re: [PATCH] [media] cpia2: fix typo in variable initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201103261928.52677.hverkuil@xs4all.nl>
Date:	Sat, 26 Mar 2011 19:28:52 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Mariusz Kozlowski <mk@....zgora.pl>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] cpia2: fix typo in variable initialisation

Hi Mariusz,

On Saturday, March 26, 2011 19:20:24 Mariusz Kozlowski wrote:
> Currently 'fh' initialises to whatever happens to be on stack. This
> looks like a typo and this patch fixes that.
> 
> Signed-off-by: Mariusz Kozlowski <mk@....zgora.pl>

If you don't mind then I'll take this patch. Although I'll probably drop it,
not because it is wrong as such but because the priority handling in cpia2
is broken big time. I intend to rewrite it using the new prio framework that
was just merged.

Luckily I finally found someone who can test this driver, so that should be
very helpful.

I hope to work on this next weekend.

Regards,

	Hans

> ---
>  drivers/media/video/cpia2/cpia2_v4l.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/cpia2/cpia2_v4l.c b/drivers/media/video/cpia2/cpia2_v4l.c
> index 5111bbc..0073a8c 100644
> --- a/drivers/media/video/cpia2/cpia2_v4l.c
> +++ b/drivers/media/video/cpia2/cpia2_v4l.c
> @@ -1313,7 +1313,7 @@ static int cpia2_g_priority(struct file *file, void *_fh, enum v4l2_priority *p)
>  static int cpia2_s_priority(struct file *file, void *_fh, enum v4l2_priority prio)
>  {
>  	struct camera_data *cam = video_drvdata(file);
> -	struct cpia2_fh *fh = fh;
> +	struct cpia2_fh *fh = _fh;
>  
>  	if (cam->streaming && prio != fh->prio &&
>  			fh->prio == V4L2_PRIORITY_RECORD)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/