linux-kernel - Re: [patch 17/23] arm: at91: Cleanup irq chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1103271747360.31464@localhost6.localdomain6>
Date:	Sun, 27 Mar 2011 17:47:55 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	LAK <linux-arm-kernel@...ts.infradead.org>,
	Lennert Buytenhek <buytenh@...tstofly.org>
Subject: Re: [patch 17/23] arm: at91: Cleanup irq chip

On Sun, 27 Mar 2011, Sergei Shtylyov wrote:

> Hello.
> 
> On 26-03-2011 0:03, Thomas Gleixner wrote:
> 
> > > Avoid the whole lazy disable dance in the demux handler by providing a
> > > irq_disable() callback.
> 
> > > Use the proper accessor functions and tidy up gpio_irq_handler()
> 
> > > Signed-off-by: Thomas Gleixner<tglx@...utronix.de>
> [...]
> 
> > > Index: linux-2.6-tip/arch/arm/mach-at91/gpio.c
> > > ===================================================================
> > > --- linux-2.6-tip.orig/arch/arm/mach-at91/gpio.c
> > > +++ linux-2.6-tip/arch/arm/mach-at91/gpio.c
> [...]
> > > @@ -384,16 +385,14 @@ static struct irq_chip gpio_irqchip = {
> > >   static void gpio_irq_handler(unsigned irq, struct irq_desc *desc)
> > >   {
> > >   	unsigned	pin;
> > > -	struct irq_desc	*gpio;
> > > -	struct at91_gpio_chip *at91_gpio;
> > > -	void __iomem	*pio;
> > > +	struct irq_data *idata = irq_desc_get_irq_data(desc);
> > > +	struct irq_chip *chip = irq_data_get_chip(data);
> > > +	struct at91_gpio_chip *at91_gpio = irq_data_get_chip_data(data);
> 
> > Sorry, needs to be
> 
> > +	struct at91_gpio_chip *at91_gpio = irq_data_get_irq_chip_data(data);
> 
> > Will fix and resend.
> 
>    You also don't have 'data' defined anywhere, maybe you meant 'ídata'?

I know, the compiler already slapped me.