linux-kernel - Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D8FF3F8.6000003@linux.intel.com>
Date:	Sun, 27 Mar 2011 19:35:36 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Lu Guanqun <guanqun.lu@...el.com>
CC:	meego-kernel@...ts.meego.com, alan@...ux.intel.com,
	fengguang.wu@...el.com, feng.tang@...el.com, michael.fu@...el.com,
	xingchao.wang@...el.com, vinod.koul@...el.com, jeeja.kp@...el.com,
	Jeff Cheng <jeff_cheng@...tron.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Ramesh Babu K V <ramesh.babu@...el.com>,
	Dharageswari R <dharageswari.r@...el.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

On 3/27/2011 7:29 PM, Lu Guanqun wrote:
>
>   	pr_debug("sst: powering dn nc_power_down ....\n");
>
> +	if (snd_pmic_ops_nc.output_dev_id == MONO_EARPIECE ||
> +	    snd_pmic_ops_nc.output_dev_id == INTERNAL_SPKR) {
> +		msleep(30);
> +		nc_set_amp_power(0);
> +	}
>   	msleep(30);

this double msleep sounds rather harsh... why do we need two of these ?
(heck... why do we need ONE ?)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/