linux-kernel - Re: [PATCH v9 1/2] mrst: export get_gpio_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110328104719.78740624@feng-i7>
Date:	Mon, 28 Mar 2011 10:47:19 +0800
From:	Feng Tang <feng.tang@...el.com>
To:	Arjan van de Ven <arjan@...ux.intel.com>
CC:	"Lu, Guanqun" <guanqun.lu@...el.com>,
	"meego-kernel@...ts.meego.com" <meego-kernel@...ts.meego.com>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"Wu, Fengguang" <fengguang.wu@...el.com>,
	"Fu, Michael" <michael.fu@...el.com>,
	"Wang, Xingchao" <xingchao.wang@...el.com>,
	"Koul, Vinod" <vinod.koul@...el.com>,
	"Kp, Jeeja" <jeeja.kp@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Ingo Molnar" <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>,
	Feng Tang <feng.tang@...ux.intel.com>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Jekyll Lai <jekyll_lai@...tron.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 1/2] mrst: export get_gpio_by_name() function

On Mon, 28 Mar 2011 10:34:22 +0800
Arjan van de Ven <arjan@...ux.intel.com> wrote:

> On 3/27/2011 7:29 PM, Lu Guanqun wrote:
> > Export get_gpio_by_name() function and make its name more focused.
> > We are doing this because currently get_gpio_by_name() is only used
> > by the devices exported from SFI DEVS table, but it is also useful
> > for other PCI devices which also use the GPIO lines, and have their
> > gpio infos in the SFI GPIO table.
> >
> 
> I can't say that I like the new name... at all.
> 
> what's "mid" ?
> what is wrong with the original name????
> 
Hi Arjan,

The original get_gpio_by_name() is static and only used in mrst.c as it's
mrst/mfld specific. So if we call it from a PCI driver, that name sounds
like a platform independent general API while it's actually mrst/mfld bound.
So we would show this dependency from the function name.

Thanks,
Feng

 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/