linux-kernel - Re: [GIT PULL] NOMMU and FRV patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Mar 2011 19:46:23 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...r.kernel.org,
	tglx@...utronix.de, amwang@...hat.com, vapier@...too.org,
	lethal@...ux-sh.org
Subject: Re: [GIT PULL] NOMMU and FRV patches

On Thu, Mar 24, 2011 at 11:03 AM, David Howells <dhowells@...hat.com> wrote:
>
> Can you pull these patches please?

No.

Because they are sh*t that have clearly never been tested, and have
never been in -next.

They don't even compile on anything but NOMMU, as far as I can tell.
That new "vcoalesce()" helper is crap:

  drivers/base/firmware_class.c: In function ‘firmware_loading_store’:
  drivers/base/firmware_class.c:251:29: error: expected expression
before ‘...’ token
  drivers/base/firmware_class.c:251:29: error: too few arguments to
function ‘vmap’
  include/linux/vmalloc.h:70:14: note: declared here

please send it to me next merge-window, when it has actually sat in -next.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/