linux-kernel - RE: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DF7A49853E29834B934025117433841F2BC81F@WHQBEMAIL3.whq.wistron>
Date:	Mon, 28 Mar 2011 11:19:45 +0800
From:	<Jeff_Cheng@...tron.com>
To:	<guanqun.lu@...el.com>, <arjan@...ux.intel.com>
Cc:	<meego-kernel@...ts.meego.com>, <alan@...ux.intel.com>,
	<fengguang.wu@...el.com>, <feng.tang@...el.com>,
	<michael.fu@...el.com>, <xingchao.wang@...el.com>,
	<vinod.koul@...el.com>, <jeeja.kp@...el.com>, <gregkh@...e.de>,
	<ramesh.babu@...el.com>, <dharageswari.r@...el.com>,
	<devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

Hi Guanqun
The msleep is to try disable pop noise. 
If you have better way to disable pop noise, please fix it.
Thanks.

-----Original Message-----
From: Lu Guanqun [mailto:guanqun.lu@...el.com] 
Sent: Monday, March 28, 2011 10:53 AM
To: Arjan van de Ven; Jeff Cheng/WHQ/Wistron
Cc: meego-kernel@...ts.meego.com; alan@...ux.intel.com; Wu, Fengguang;
Tang, Feng; Fu, Michael; Wang, Xingchao; Koul, Vinod; Kp, Jeeja; Greg
Kroah-Hartman; Babu, Ramesh; R, Dharageswari;
devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO
line

On Mon, Mar 28, 2011 at 10:35:36AM +0800, Arjan van de Ven wrote:
> On 3/27/2011 7:29 PM, Lu Guanqun wrote:
> >
> >   	pr_debug("sst: powering dn nc_power_down ....\n");
> >
> > +	if (snd_pmic_ops_nc.output_dev_id == MONO_EARPIECE ||
> > +	    snd_pmic_ops_nc.output_dev_id == INTERNAL_SPKR) {
> > +		msleep(30);
> > +		nc_set_amp_power(0);
> > +	}
> >   	msleep(30);
> 
> this double msleep sounds rather harsh... why do we need two of these
?
> (heck... why do we need ONE ?)
> 

This is legacy code from Jeff Cheng's patch.
Jeff, could you provide some information on this line?

-- 
guanqun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/