linux-kernel - Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110328055121.GB27949@kroah.com>
Date:	Sun, 27 Mar 2011 22:51:21 -0700
From:	Greg KH <greg@...ah.com>
To:	Lu Guanqun <guanqun.lu@...el.com>
Cc:	meego-kernel@...ts.meego.com, alan@...ux.intel.com,
	arjan@...ux.intel.com, fengguang.wu@...el.com, feng.tang@...el.com,
	michael.fu@...el.com, xingchao.wang@...el.com,
	vinod.koul@...el.com, jeeja.kp@...el.com,
	Jeff Cheng <jeff_cheng@...tron.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Ramesh Babu K V <ramesh.babu@...el.com>,
	Dharageswari R <dharageswari.r@...el.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line

On Mon, Mar 28, 2011 at 10:29:20AM +0800, Lu Guanqun wrote:
> This patch originates from Jeff Cheng's patch to enable the internal speaker.

I don't understand this, why is it in the changelog entry?

> On Moorestown platform, internal speaker's power line is connected to a GPIO
> line, this information is got from SFI GPIO table, so we need set it to 1 to
> enable the internal speaker, or set it to 0 to disable it.
> 
> When we set the output device, we power on or off the internal speaker on demand.

What happens without this patch?  Is this a feature you are adding to
the driver, or a bugfix?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/