linux-kernel - Re: [PATCH] uio: fix allocating minor id for uio device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110329084055.GB2901@pengutronix.de>
Date:	Tue, 29 Mar 2011 10:40:55 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	"Hans J. Koch" <hjk@...sjkoch.de>
Cc:	Hillf Danton <dhillf@...il.com>, Greg KH <gregkh@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] uio: fix allocating minor id for uio device


> > -	idev->minor = id & MAX_ID_MASK;
> > +	if (id < UIO_MAX_DEVICES)
> > +		idev->minor = id;
> > +	else {

As it needs respinning anyway: If the else-block has braces, it is
recommended for the if-block, too

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)