linux-kernel - Re: [PATCH] Fix build failure when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oc4u4rn4.fsf@devron.myhome.or.jp>
Date:	Tue, 29 Mar 2011 10:55:27 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Shyam_Iyer@...l.com, jbarnes@...tuousgeek.org, mjg59@...f.ucam.org,
	Narendra_K@...l.com, viro@...iv.linux.org.uk, sfr@...b.auug.org.au,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	Matt_Domsch@...l.com, Charles_Rose@...l.com,
	Jordan_Hargrave@...l.com
Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig

Randy Dunlap <randy.dunlap@...cle.com> writes:

>> I don't get this.. you should not be getting CONFIG_NLS=m unless you
>> have stripped you config files really.. :-) Is it possible to get
>> your .config to hit this issue.
>
> I haven't stripped any config files -- but they are randconfig files.
> Two (2) config files that cause build failures are attached.

config PCI_IOAPIC
	bool
	depends on PCI
	depends on ACPI
	depends on HOTPLUG
	default y

select NLS if (DMI || ACPI)

I guess this is simply wrong. It will be parsed as

config PCI_IOAPIC
	bool
	depends on PCI
	depends on ACPI
	depends on HOTPLUG
	default y
	select NLS if (DMI || ACPI)

How about something like the following?

config PCI_LABEL
	bool
        select NLS
        depends on (DMI || ACPI)
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/