linux-kernel - Re: [PATCH 2/3] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1103291408150.1844@chino.kir.corp.google.com>
Date:	Tue, 29 Mar 2011 14:11:53 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Daniel Kiper <dkiper@...-space.pl>
cc:	ian.campbell@...rix.com, akpm@...ux-foundation.org,
	andi.kleen@...el.com, haicheng.li@...ux.intel.com,
	fengguang.wu@...el.com, jeremy@...p.org, konrad.wilk@...cle.com,
	dan.magenheimer@...cle.com, v.tolstov@...fip.ru, pasik@....fi,
	dave@...ux.vnet.ibm.com, wdauchy@...il.com,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH 2/3] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN()
 macro

On Tue, 29 Mar 2011, Daniel Kiper wrote:

> > These are only valid for CONFIG_SPARSEMEM, so they need to be defined 
> > conditionally.
> 
> OK, however, I think that pfn_to_section_nr()/section_nr_to_pfn()
> should be defined conditionally, too.
> 

Yes, and you could try removing this from include/linux/mm.h:

#ifndef PFN_SECTION_SHIFT
#define PFN_SECTION_SHIFT 0 
#endif

then we'll reveal anything using these conversion macros that don't rely 
on sparsemem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/