linux-kernel - Re: kmemleak for MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301491622.3283.46.camel@edumazet-laptop>
Date:	Wed, 30 Mar 2011 15:27:02 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Maxin John <maxin.john@...il.com>
Cc:	Daniel Baluta <daniel.baluta@...il.com>,
	Catalin Marinas <catalin.marinas@....com>,
	naveen yadav <yad.naveen@...il.com>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: kmemleak for MIPS

Le mercredi 30 mars 2011 à 14:17 +0100, Maxin John a écrit :
> Hi,
> 
> I have compiled the kernel with below given modification in .config
> 
> CONFIG_CMDLINE="uhash_entries=256"
> 
> After booting with the new kernel, the "kmemleak" no longer complains
> about the "udp_table_init".
> However it do report another possible leak :)
> 
> debian-mips:~# cat /sys/kernel/debug/kmemleak
> unreferenced object 0x8f085000 (size 4096):
>   comm "swapper", pid 1, jiffies 4294937670 (age 1043.280s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<801ac7a8>] __kmalloc+0x130/0x180
>     [<80532500>] flow_cache_cpu_prepare+0x50/0xa8
>     [<8052378c>] flow_cache_init_global+0x90/0x138
>     [<80100584>] do_one_initcall+0x174/0x1e0
>     [<8050c348>] kernel_init+0xe4/0x174
>     [<80103d4c>] kernel_thread_helper+0x10/0x18
> debian-mips:~#

Hmm, then MIPS kmemleak port might have a problem with percpu data ?

fcp->hash_table = kzalloc_node(sz, GFP_KERNEL, cpu_to_node(cpu));

fcp is a per cpu "struct flow_cache_percpu"

> I completely agree with Daniel. Shall we move on and integrate the
> kmemleak support for MIPS ?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/