linux-kernel - Re: [PATCH -rc1] msi-laptop: fix config-dependent build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4D94BCC7020000230002AA34@novprvlin0050.provo.novell.com>
Date:	Thu, 31 Mar 2011 00:41:27 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<randy.dunlap@...cle.com>
Cc:	<torvalds@...ux-foundation.org>, <mjg@...hat.com>,
	<linux-kernel@...r.kernel.org>,
	<platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH -rc1] msi-laptop: fix config-dependent build error

於 三，2011-03-30 於 15:20 -0700，Randy Dunlap 提到：
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> The msi-laptop driver uses input_*() and sparse_keymap_*() interfaces.
> It should depend on the INPUT subsystem being present and select
> INPUT_SPARSEKMAP so that those interfaces are present.
> 
> ERROR: "input_free_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "input_register_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "sparse_keymap_setup" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "input_allocate_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "sparse_keymap_report_event" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "input_unregister_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "sparse_keymap_free" [drivers/platform/x86/msi-laptop.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Matthew Garrett <mjg@...hat.com>
> Cc: "Lee, Chun-Yi" <jlee@...ell.com>
> ---
>  drivers/platform/x86/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- lnx-2639-rc1.orig/drivers/platform/x86/Kconfig
> +++ lnx-2639-rc1/drivers/platform/x86/Kconfig
> @@ -187,7 +187,8 @@ config MSI_LAPTOP
>  	depends on ACPI
>  	depends on BACKLIGHT_CLASS_DEVICE
>  	depends on RFKILL
> -	depends on SERIO_I8042
> +	depends on INPUT && SERIO_I8042
> +	select INPUT_SPARSEKMAP
>  	---help---
>  	  This is a driver for laptops built by MSI (MICRO-STAR
>  	  INTERNATIONAL):
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thank's, it's good to me!

Acked-by: "Lee, Chun-Yi" <jlee@...ell.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/