linux-kernel - Re: [PATCH 15/23] msi-laptop: pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4D94BCCC020000230002AA37@novprvlin0050.provo.novell.com>
Date:	Thu, 31 Mar 2011 00:41:32 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<joe@...ches.com>
Cc:	<mjg@...hat.com>, <linux-kernel@...r.kernel.org>,
	<platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH 15/23] msi-laptop: pr_<level> neatening

於 二，2011-03-29 於 15:21 -0700，Joe Perches 提到：
> Just making it a bit more like other logging message uses.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/platform/x86/msi-laptop.c |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> index 23fb2af..f89c0b6 100644
> --- a/drivers/platform/x86/msi-laptop.c
> +++ b/drivers/platform/x86/msi-laptop.c
> @@ -447,7 +447,7 @@ static struct platform_device *msipf_device;
>  
>  static int dmi_check_cb(const struct dmi_system_id *id)
>  {
> -	pr_info("Identified laptop model '%s'.\n", id->ident);
> +	pr_info("Identified laptop model '%s'\n", id->ident);
>  	return 1;
>  }
>  
> @@ -875,8 +875,7 @@ static int __init msi_init(void)
>  	/* Register backlight stuff */
>  
>  	if (acpi_video_backlight_support()) {
> -		pr_info("Brightness ignored, must be controlled "
> -		       "by ACPI video driver\n");
> +		pr_info("Brightness ignored, must be controlled by ACPI video driver\n");
>  	} else {
>  		struct backlight_properties props;
>  		memset(&props, 0, sizeof(struct backlight_properties));
> @@ -930,7 +929,7 @@ static int __init msi_init(void)
>  	if (auto_brightness != 2)
>  		set_auto_brightness(auto_brightness);
>  
> -	pr_info("driver "MSI_DRIVER_VERSION" successfully loaded.\n");
> +	pr_info("driver " MSI_DRIVER_VERSION " successfully loaded\n");
>  
>  	return 0;
>  
> @@ -978,7 +977,7 @@ static void __exit msi_cleanup(void)
>  	if (auto_brightness != 2)
>  		set_auto_brightness(1);
>  
> -	pr_info("driver unloaded.\n");
> +	pr_info("driver unloaded\n");
>  }
>  
>  module_init(msi_init);

Thank's, it's ok to me.

Acked-by: Lee, Chun-Yi <jlee@...ell.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/