linux-kernel - Re: [PATCH] tty/n_gsm: fix bug in CRC calculation for gsm1 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110331131144.74a579db@lxorguk.ukuu.org.uk>
Date:	Thu, 31 Mar 2011 13:11:44 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com>
Cc:	linux-serial@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	stable@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty/n_gsm: fix bug in CRC calculation for gsm1 mode

On Sun, 27 Mar 2011 04:05:00 +0400
Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com> wrote:

> Problem description:
>   gsm_queue() calculate a CRC for arrived frames. As a last step of
>   CRC calculation it call
> 
>     gsm->fcs = gsm_fcs_add(gsm->fcs, gsm->received_fcs);
> 
>   This work perfectly for the case of GSM0 mode as gsm->received_fcs
>   contain the last piece of data required to generate final CRC.
> 
>   gsm->received_fcs is not used for GSM1 mode. Thus we put an
>   additional byte to CRC calculation. As result we get a wrong CRC
>   and reject incoming frame.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@...il.com>

Acked-by: Alan Cox <alan@...ux.intel.com>

(This wants cleaning up better as Mikhael also says but this patch is
clear and unlike a big clean up a better base point for a stable fix and
can be reworked further)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/