linux-kernel - RE: gpio: pca953x: prevent freeing IRQ 0 on probe error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0D753D10438DA54287A00B027084269764D1B0C9B0@AUSP01VMBX24.collaborationhost.net>
Date:	Thu, 31 Mar 2011 16:20:04 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: RE: gpio: pca953x: prevent freeing IRQ 0 on probe error

On Thursday, March 31, 2011 1:49 PM, Grant Likely wrote:
> On Fri, Mar 25, 2011 at 03:02:54PM -0700, H Hartley Sweeten wrote:
>> If CONFIG_GPIO_PCA953X_IRQ is enabled and an error occurs in the probe
>> before pca953x_irq_setup() is called chip->client->irq will be 0 due to
>> the kmalloc.  pca953x_irq_teardown() will then try to free_irq(0, chip)
>> which will produce a:
>> 
>> 	WARN(1, "Trying to free already-free IRQ %d\n", irq);
>> 
>> Add an error path to prevent this.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
>> Cc: Grant Likely <grant.likely@...retlab.ca>
>
> Thanks for catching this Hartley.
>
> Ben also submitted a patch for this and I ended up looking at his patch 
> first, so that is what's applied.  :-)

Not a problem. Thanks!
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/