linux-kernel - Re: accessing vfpinstr macros from outside vfp directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301678843.17592.5.camel@e102144-lin.cambridge.arm.com>
Date:	Fri, 01 Apr 2011 18:27:23 +0100
From:	Will Deacon <will.deacon@....com>
To:	Neil Leeder <nleeder@...eaurora.org>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Jean Pihet <jean.pihet@...oldbits.com>,
	Sheetal Sahasrabudhe <sheetals@...eaurora.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, jamie.iles@...ochip.com,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: accessing vfpinstr macros from outside vfp directory

Neil,

On Tue, 2011-03-29 at 22:04 +0100, Neil Leeder wrote:
> Any opinions on what would be the best thing to do here? Choices appear to be:
> 
> 1) allow the relative include path of ../vfp/vfpinstr.h
> 2) move the definitions of fmrx, fmxr from vfp/vfpinstr.h to include/asm/vfp.h
> 3) move vfp/vfpinstr.h to include/asm
> 4) other...?
> 
> If it helps, I can create a patch for whichever is considered the preferred solution.
> 

I personally don't find option (1) that offensive - Bryan seemed to
differ though so perhaps option (2) would keep him happy?

I don't think option (3) is sensible given that the majority of the
header file is private to /vfp.

Will

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/